Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table styles do not convey to .ck-content? #6314

Closed
Reinmar opened this issue Feb 24, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-table#296
Closed

Table styles do not convey to .ck-content? #6314

Reinmar opened this issue Feb 24, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-table#296
Assignees
@panr
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 24, 2020

📝 Provide detailed reproduction steps (if any)

image

✔️ Expected result

I'd expect to see a similarly styled table on the right.

❌ Actual result

Styles are significantly different.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 24, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Feb 24, 2020

AFAICS, it's only about the border in td/th and alignment in th.

@Reinmar Reinmar changed the title Table styles do not conveyed to .ck-content? Table styles do not convey to .ck-content? Feb 24, 2020
@Reinmar Reinmar mentioned this issue Mar 3, 2020
Closed
@Reinmar Reinmar modified the milestones: iteration 30, iteration 31 Mar 9, 2020
@panr panr mentioned this issue Apr 2, 2020
Merged
@panr
Copy link
Contributor

panr commented Apr 2, 2020 •
edited
Loading

Fix is ready to review.

Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 3, 2020
@Reinmar
Merge pull request #296 from ckeditor/i/6314
0e0e6fe 
Fix: Table border should be present in content styles (should use `.ck-content`). Closes ckeditor/ckeditor5#6314.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #296 from ckeditor/i/6314
9dca7b5 
Fix: Table border should be present in content styles (should use `.ck-content`). Closes #6314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

i/6314: Add missing border styling to the table th and td ckeditor/ckeditor5-table
3 participants
@Reinmar @panr @mlewand