-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockToolbar looses its position and width #6570
BlockToolbar looses its position and width #6570
Comments
This could be either very simple or quite nasty. I gave it a quick look. There's this moment when the I didn't go deeper but maybe I'll spend and hour or two to debug this. |
Related: #6575 |
Feature: The `BlockToolbar` should group items when there is no place to show them all. Closes ckeditor/ckeditor5#6449. Closes ckeditor/ckeditor5#6575. Closes ckeditor/ckeditor5#6570. Bulletproofed the `ToolbarView#maxWidth` and items grouping when the toolbar is invisible.
Fix: Do not execute `ResizeObserver` callbacks when the resized element is invisible (but still in DOM) (see ckeditor/ckeditor5#6570).
Fix: Do not execute `ResizeObserver` callbacks when the resized element is invisible (but still in DOM) (see #6570).
📝 Provide detailed reproduction steps (if any)
💡This issue has been created before the code got merged and it exists only locally in situation where
BlockToolbar
has implementedshouldGroupWhenFull
.The issue is needed only as a reference to possibly existing bug and it is related to #6449.
BlockToolbar
to group items.✔️ Expected result
Toolbar panel should be anchored correctly to the block toolbar button each time.
❌ Actual result
Toolbar panel is anchored correctly only the first time you show it. It resets the position and width only when view has been resized.
The text was updated successfully, but these errors were encountered: