Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The table tests are wrong #6574

Closed
jodator opened this issue Apr 8, 2020 · 0 comments · Fixed by #7410
Closed

The table tests are wrong #6574

jodator opened this issue Apr 8, 2020 · 0 comments · Fixed by #7410
Assignees
@jodator
Labels
package:table type:refactor This issue requires or describes a code refactoring. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 33 (v20...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 8, 2020

Provide a description of the task

This issue comes from time to time - most of the table tests works on defaultSchema() and defaultConversion() utilities.

Why it is this way - mostly because other features' tests work in detachment from it's FeatureEditing part. Examples: list command, paragraph command, etc. However I see that other features tests are written using the FeatureEditing so it might be a case that we switched the approach somewhere or we have two.

Rewriting all the tests might be a huge task but I see a potential benefit of having proper tests for table.

Unfortunately, some tests cannot be simply rewritten by removing defaultConversion() helpers because the tests assumes other configuration (example - the conversion tests assumes operating on data pipeline converters (without widget styling).
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". package:table type:refactor This issue requires or describes a code refactoring. labels Apr 8, 2020
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 8, 2020
@jodator
Duplicate beforeEach call to make test independent. See ckeditor/cked…
737c166 
…itor5#6574.
@jodator jodator mentioned this issue Apr 8, 2020
Merged
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 10, 2020
@jodator
Use TableEditing in some of table utils tests. See ckeditor/ckeditor5…
91b8ba6 
…#6574.
@jodator jodator mentioned this issue Apr 10, 2020
Merged
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 15, 2020
@jodator
Use TableEditing in RemoveRowCommand tests. See ckeditor/ckeditor5#6574.
1ec631c
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 15, 2020
@jodator
Use TableEditing in downcast heading rows change tests. See ckeditor/…
53cc8f7 
…ckeditor5#6574.
@Mgsy Mgsy added this to the nice-to-have milestone Apr 27, 2020
mlewand pushed a commit that referenced this issue May 1, 2020
@jodator
Duplicate beforeEach call to make test independent. See #6574.
b404b34
mlewand pushed a commit that referenced this issue May 1, 2020
@jodator
Use TableEditing in some of table utils tests. See #6574.
5ab8c1b
mlewand pushed a commit that referenced this issue May 1, 2020
@jodator
Use TableEditing in RemoveRowCommand tests. See #6574.
6ec26cc
mlewand pushed a commit that referenced this issue May 1, 2020
@jodator
Use TableEditing in downcast heading rows change tests. See #6574.
ede9085
@jodator jodator mentioned this issue May 26, 2020
Closed
@jodator jodator self-assigned this Jun 2, 2020
@jodator jodator modified the milestones: nice-to-have, iteration 33 Jun 2, 2020
@jodator jodator mentioned this issue Jun 9, 2020
Merged
niegowski added a commit that referenced this issue Jun 10, 2020
@niegowski
Merge pull request #7410 from ckeditor/i/6574
b127f41 
Tests (table): Use real schema and conversion definitions in table tests. Closes #6574.

Other (table): Removed `options.asWidget` from most of the table converters which are never run in data pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:refactor This issue requires or describes a code refactoring. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

6574: Use TableEditing in tests. ckeditor/ckeditor5
2 participants
@jodator @Mgsy