Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse paths to manual tests correctly #7093

Closed
Reinmar opened this issue Mar 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-dev#642
Closed

Parse paths to manual tests correctly #7093

Reinmar opened this issue Mar 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-dev#642
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 33 (v20...

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 26, 2018

image

The first test is in fact placed in ckeditor5-engine/tests/manual/ckeditor5-721/...

We changed this on the occasion of ckeditor/ckeditor5-dev#386, but we need to handle this case more specifically.

The easiest solution I can think of is to require that ckeditor5-* is followed by tests/.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the unknown milestone May 18, 2020
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:dev labels May 18, 2020
@pomek pomek mentioned this issue May 25, 2020
Merged
jodator added a commit to ckeditor/ckeditor5-dev that referenced this issue May 25, 2020
@jodator
Merge pull request #642 from ckeditor/i/7280
ccd299e 
Fix (tests): The getRelativeFilePath() util will return proper paths for CKEditor 5 builds. Closes ckeditor/ckeditor5#7280. Closes ckeditor/ckeditor5#7093.
@Reinmar Reinmar modified the milestones: unknown, iteration 33 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

Manual test server will parse builds ckeditor/ckeditor5-dev
2 participants
@Reinmar @mlewand