Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run release:publish should not result with an error #7300

Closed
mlewand opened this issue May 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#645
Closed

npm run release:publish should not result with an error #7300

mlewand opened this issue May 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#645
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented May 27, 2020

📝 Provide detailed reproduction steps (if any)

During the 19.1.0 release after running npm run release:publish we had following error:

Pushing "ckeditor5" package...
To github.com:ckeditor/ckeditor5.git
 * [new tag]               v19.1.0 -> v19.1.0
 ! [rejected]              master -> master (non-fast-forward)
error: failed to push some refs to 'git@github.com:ckeditor/ckeditor5.git'
hint: Updates were rejected because a pushed branch tip is behind its remote
hint: counterpart. Check out this branch and integrate the remote changes
hint: (e.g. 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Error while executing git push origin master v19.1.0: To github.com:ckeditor/ckeditor5.git
 * [new tag]               v19.1.0 -> v19.1.0
 ! [rejected]              master -> master (non-fast-forward)
error: failed to push some refs to 'git@github.com:ckeditor/ckeditor5.git'
hint: Updates were rejected because a pushed branch tip is behind its remote
hint: counterpart. Check out this branch and integrate the remote changes
hint: (e.g. 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

This place should be adjusted: https://github.com/ckeditor/ckeditor5-dev/blob/e67b9e9c9dd484d575f301027929ac85129a37b6/packages/ckeditor5-dev-env/lib/release-tools/tasks/releasesubrepositories.js#L570


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels May 27, 2020
@mlewand mlewand added this to the iteration 33 milestone May 27, 2020
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue May 31, 2020
Fix (env): The `releaseSubRepositories()` task should not throw any error if publishing from the non-master branch. Closes ckeditor/ckeditor5#7300.
pomek added a commit that referenced this issue Jun 1, 2020
Internal (ckeditor5): Use the `release` branch for publishing changes. See #7300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants