Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for generating a changelog for single package behaves incorrectly for the "skip" option #7402

Closed
ma2ciek opened this issue Jun 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#648
Closed

Script for generating a changelog for single package behaves incorrectly for the "skip" option #7402

ma2ciek opened this issue Jun 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#648
Assignees
@pomek
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 33 (v20...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 8, 2020

The changelog generator creates the vundefined for that option:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 10e86782..2e10fee9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,7 +1,7 @@
 Changelog
 =========

-## 19.0.2 (2020-05-25)
+undefined## 19.0.2 (2020-05-25)

The bug probably happens here as the code jumps from Promise.resolve() to the next then()while it should return.
@ma2ciek ma2ciek added type:bug This issue reports a buggy (incorrect) behavior. package:dev labels Jun 8, 2020
@pomek pomek added the squad:platform Issue to be handled by the Platform team. label Jun 8, 2020
@pomek pomek added this to the iteration 33 milestone Jun 8, 2020
@pomek pomek mentioned this issue Jun 8, 2020
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Jun 9, 2020
@pomek
Merge pull request #648 from ckeditor/i/7402
682d31e 
Fix: When typed "skip" as a new version, the changelog generator should abort the process instead of writing invalid entries to the changelog file. Closes ckeditor/ckeditor5#7402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

Changelog generator - "skip" breaks the process ckeditor/ckeditor5-dev
2 participants
@pomek @ma2ciek