Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting multiple cells leaves the selection while TableSelection is disabled #7486

Closed
Mgsy opened this issue Jun 23, 2020 · 1 comment · Fixed by #7615
Closed

Pasting multiple cells leaves the selection while TableSelection is disabled #7486

Mgsy opened this issue Jun 23, 2020 · 1 comment · Fixed by #7615
Assignees
@niegowski
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 34 (v21...

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 23, 2020

📝 Provide detailed reproduction steps (if any)

  1. Insert a table.
  2. Select two cells and copy them.
  3. Disable TableSelection - editor.plugins.get( 'TableSelection' ).forceDisabled().
  4. Put the caret in a cell.
  5. Paste.

✔️ Expected result

The selection is collapsed.

❌ Actual result

Multiple cells are selected.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:table labels Jun 23, 2020
@Reinmar Reinmar added this to the next milestone Jun 23, 2020
@jodator
Copy link
Contributor

jodator commented Jun 23, 2020

Handle this in setCellSelection() to not set multi-cell selection.

@Reinmar Reinmar modified the milestones: next, iteration 34 Jun 23, 2020
@niegowski niegowski self-assigned this Jul 13, 2020
@niegowski niegowski mentioned this issue Jul 13, 2020
Merged
jodator added a commit that referenced this issue Jul 14, 2020
@jodator
Merge pull request #7615 from ckeditor/i/7486
e50a4e1 
Fix (table): Pasting table into a table should not set multi-cell selection if TableSelection plugin is disabled. Closes #7486.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 34 (v21.0.0)
4 participants
@Reinmar @jodator @niegowski @Mgsy