Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post link placeholder should be commented out by default #7954

Closed
mlewand opened this issue Aug 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#665
Closed

Blog post link placeholder should be commented out by default #7954

mlewand opened this issue Aug 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#665
Assignees
@mlewand
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 36 (v23...

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 27, 2020

Provide a description of the task

When generating the changelog section for a release, we put a "TODO: Add a link to the blog post." which always makes it into mails (the saddest part), GH release page etc.

If we comment it out at least there will be no placeholder, but we can still add the blog post later on.
@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. package:dev labels Aug 27, 2020
@mlewand mlewand added this to the backlog milestone Aug 27, 2020
@mlewand mlewand mentioned this issue Aug 27, 2020
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Aug 31, 2020
@pomek
Merge pull request #665 from ckeditor/changelog-blog-post-commented
8ce5f25 
Other (env): The changelog generator now produces a commented out blog post placeholder by default. Closes ckeditor/ckeditor5#7954.
@mlewand mlewand self-assigned this Sep 9, 2020
@mlewand mlewand modified the milestones: backlog, iteration 36 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 36 (v23.0.0)
1 participant
@mlewand