Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font family and size with supportAllValues does not load #7965

Closed
dkrahn opened this issue Aug 28, 2020 · 2 comments · Fixed by #8928
Closed

Font family and size with supportAllValues does not load #7965

dkrahn opened this issue Aug 28, 2020 · 2 comments · Fixed by #8928
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dkrahn
Copy link
Contributor

dkrahn commented Aug 28, 2020

📝 Provide detailed reproduction steps (if any)

  1. Go to online document demo;
  2. From console paste
editors[0].setData('<figure class="table"><table><tbody><tr><td><span style="font-family:Arial, Helvetica, sans-serif;font-size:11px;">Font Arial 11</span></td></tr></tbody></table></figure>')
  1. Check the applied font.

✔️ Expected result

Should show a table with content Font Arial 11 in Arial font and size 11px

❌ Actual result

Shows a table with content Font Arial 11 with no font styles applied

📃 Other details

Apparently changing the upcast conversion to elementToAttribute instead of attributeToAttribute in the _prepareAnyValueConverters resolves the problem.
But I am not sure if this is the correct way to solve it.

  • Browser: Chrome
  • OS: Windows
  • CKEditor version: 21.0.0
  • Installed CKEditor plugins: Default

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dkrahn dkrahn added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 28, 2020
@FilipTokarski
Copy link
Member

Hi, thanks for the report. I can confirm this.
When I remove supportAllValues: true everything seems to be fine.

@dkrahn
Copy link
Contributor Author

dkrahn commented Oct 1, 2020

Any plans to fix this?

@mlewand mlewand added this to the nice-to-have milestone Oct 12, 2020
pomek added a commit that referenced this issue Feb 4, 2021
Fix (font): Fixed the `supportAllValues` configuration for the `FontSize` and `FontFamily` features to work with nested elements (tables). Closes #7965.

Thanks to @dkrahn!
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 40 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants