-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing in the toolbar and buttons #820
Comments
I had the same feelings working on Letters. Spacing is important especially in the balloon toolbar where for example we have only four buttons (bold, italic, link, comment). I think we can easily enlarge padding of buttons (without changing icon size) from: Current padding 0.15em for buttonsProposal padding 0.25em |
My problem wasn't necessarily padding, but just space between icons. It could be also solved with margin. I am not saying that adding more padding is wrong, just stating that it's not strictly about padding. It's also a question about how much space we want to have between two selected buttons. |
After a discussion with @oleq and @dkonopka I changed the title of this ticket to also cover spacing inside buttons and all types of spacing around buttons (and not only spacing between buttons). One of the ideas (which @pjasiun brought) was to limit the spacing between toolbar and icons to have more "padding-less" effect: We can also add spacing inside buttons (around icons): To compare, this is the current state: |
Unfortunately making the spacing around the buttons is not an option because it starts looking weird in balloons which have arrows. Check out my previous comment (section "Paddings in the UI"). |
Other: Increased the spacing in the toolbar by making the buttons bigger. Unified rendering of several components. Closes ckeditor/ckeditor5#820.
I have a feeling, that spacing between icons is too small. Toolbar feels crowded, compressed, narrowed. I feel that in the old theme there was just enough "air" between icons.
You can see how those changed here: https://user-images.githubusercontent.com/1099479/35739226-3d784046-0831-11e8-9528-ed16a9df86f3.gif
I also feel like it wouldn't be bad if the toolbar was a tad higher (like it was). Although that might look bad with new dropdown design.
The text was updated successfully, but these errors were encountered: