Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine the accessible (material) inputs PoC #8242

Closed
oleq opened this issue Oct 12, 2020 · 1 comment · Fixed by #8267
Closed

Refine the accessible (material) inputs PoC #8242

oleq opened this issue Oct 12, 2020 · 1 comment · Fixed by #8267
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark package:ui squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 37 (v23...

Comments

@oleq
Copy link
Member

oleq commented Oct 12, 2020

Provide a description of the task

A follow-up of #1098 and #7952.
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:theme-lark package:ui domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Oct 12, 2020
@oleq oleq added this to the iteration 37 milestone Oct 12, 2020
@oleq oleq self-assigned this Oct 12, 2020
This was referenced Oct 12, 2020
Closed
Merged
@Reinmar
Copy link
Member

Reinmar commented Oct 26, 2020

Let's close this (as the effort was done when putting #8267) one and track the remaining things in the original ticket (#1098).

@Reinmar Reinmar closed this as completed Oct 26, 2020
Reinmar added a commit that referenced this issue Nov 5, 2020
@Reinmar
Merge pull request #8267 from ckeditor/i/1098-accessible-input-labels
407a8a7 
Feature: Made input labels accessible across the editor UI. Closes #1098. Closes #8242.

MAJOR BREAKING CHANGE (theme-lark): The look and behavior of the `LabeledFieldView` UI component (used for displaying fields across the project) have changed. This may require changes in your integration if it customizes the `.ck-labeled-field-view` selector (or its internals).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark package:ui squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 37 (v23.1.0)
Development

Successfully merging a pull request may close this issue.

#1098: Made input labels accessible across the editor UI ckeditor/ckeditor5
2 participants
@Reinmar @oleq