Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw HTML widget buttons don't reflect commands state #8357

Closed
scofalik opened this issue Oct 27, 2020 · 1 comment · Fixed by #8421
Closed

Raw HTML widget buttons don't reflect commands state #8357

scofalik opened this issue Oct 27, 2020 · 1 comment · Fixed by #8421
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@scofalik
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

Raw HTML widget buttons don't reflect commands state. When the editing command is disabled, the edit and save buttons should be disabled as well. This happens for example when track changes is turned off (the feature is not yet integrated with TC).
@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. package:html-embed labels Oct 27, 2020
@Mgsy Mgsy added domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Nov 2, 2020
@Mgsy Mgsy added this to the nice-to-have milestone Nov 2, 2020
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 38 Nov 2, 2020
@pkwasnik pkwasnik self-assigned this Nov 5, 2020
@pkwasnik
Copy link
Contributor

pkwasnik commented Nov 5, 2020

We agreed with @scofalik that only the save button should be disabled when editing command is disabled. Edit button can't be linked to updateHtmlEmbed. It is disabled when the focus is outside of the widged, so each time user will want to edit, will need first to select the widged. Anyway for edit button it is not a problem to stay enabled.

@pkwasnik pkwasnik mentioned this issue Nov 5, 2020
Merged
@pkwasnik pkwasnik mentioned this issue Nov 16, 2020
Closed
jodator added a commit that referenced this issue Nov 20, 2020
@jodator
Merge pull request #8421 from ckeditor/i/8357
b2805dd 
Fix (html-embed): The save button will now reflect commands state. Closes #8357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Reflecting commands state by save button. ckeditor/ckeditor5
4 participants
@Reinmar @scofalik @pkwasnik @Mgsy