-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review toolbars in the demos in the documentation to improve feature discoverability #8493
Comments
Checked and eliminated all the ones that do not have a toolbar or the toolbar is proper length and there is no need for the indicator. |
Toolbar guide has been extracted from the configuration guide and added as a standalone guide to aid discoverability and overcome the search engine standard issue. |
There is a larger discussion coming, we already took up this topic with @pkwasnik and @Mgsy. Now:
If the latter, we could introduce the wrapping switch straight into the editor base, because putting it in every one of those demos would require a substantial amount of code, as they do not have toolbar items listed and would need to. Also future feature request on my part: allow automatic wrapping but set a predefined breakpoint. This is a combo approach between "wrap only as needed" and "wrap here so it looks good" that would produce the ultimate visual results for the editor. |
Tooltip indicators for buttons were added where applicable with an enormous amount of help from @pkwasnik. Sometimes more than one tooltip was added if there was more than one demo and it made sense. Other changes: all lists have been grouped into one submenu, as it makes sense to keep them together both functionally and logically. Images guide shall be anyway rewritten largely, so it was not tended to too carefully (just one indicator added, this may change once the guide is slashed into pieces). |
Moved the toolbar indicator task to a separate issue: https://github.com/cksource/ckeditor5-internal/issues/588 |
There are still some unchecked guides in the list - @godai78 can you review them, propose changes if any are needed or check them and let's close this issue finally? |
Sure. |
|
@pkwasnik - do we have power over it? The PDF exporter indeed looks like this: |
Yes, it's configurable. When I first created one for the PDF export guide I consciously made it look like this. |
Share the knowledge, please :) |
Never mind, I guess I found it. |
You can use any of https://atomiks.github.io/tippyjs/v6/all-props/ options there. |
Had I known of its existence before, that would have had been much splendid indeed. I'm taking the link to the documentation tech-tips database, thank you.. |
Docs: Toolbars, toolbar indicators and demo content fixes in Features. Closes: #8493
Closed in 37dac1d. Hell of a ride it was! Thanks! 👏 |
It would be great if we could measure the impact of these changes. For instance, changes to the average visit/session duration for individual guides from Google Analytics would be very helpful. |
After multiline toolbar and marking UI buttons in the docs are done, we should review all demos and see:
Toolbars checked / adjusted:
Toolbar tooltips added (including demos that do not need the tooltips):
The text was updated successfully, but these errors were encountered: