Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML embed won't save if the content was not changed #8560

Closed
oleq opened this issue Dec 1, 2020 · 0 comments · Fixed by #8562
Closed

HTML embed won't save if the content was not changed #8560

oleq opened this issue Dec 1, 2020 · 0 comments · Fixed by #8562
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Dec 1, 2020 •
edited
Loading

  1. Go to http://fake.ckeditor.com:8125/ckeditor5-html-embed/tests/manual/htmlembed.html.
  2. Edit an embed.
  3. Click "save".

Expected

The content of the embed was saved.

Actual

Nothing happens. There's no error.

2020-12-01 12.04.43.gif

It's a regression introduced in it38. It works fine on stable https://ckeditor.com/docs/ckeditor5/latest/features/html-embed.html.
@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed squad:dx type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases. labels Dec 1, 2020
@oleq oleq added this to the iteration 38 milestone Dec 1, 2020
@pkwasnik pkwasnik self-assigned this Dec 1, 2020
@pkwasnik pkwasnik mentioned this issue Dec 1, 2020
Merged
@oleq oleq modified the milestones: iteration 38, iteration 39 Dec 3, 2020
@oleq oleq closed this as completed in #8562 Dec 4, 2020
oleq added a commit that referenced this issue Dec 4, 2020
@oleq
Merge pull request #8562 from ckeditor/i/8560
5e26d53 
Fix (html-embed): Save button should close the source editor even if there is no changes. Closes #8560.
@Reinmar Reinmar modified the milestones: iteration 39, iteration 38 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Save button should close editor even if there is no changes. ckeditor/ckeditor5
3 participants
@Reinmar @oleq @pkwasnik