-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust releasing scripts to handle changes related to DLL #8616
Comments
The How it looks now in the code: ckeditor5/scripts/release/publish.js Lines 31 to 38 in b963b0c
In fact, the
We could improve the function by renaming the One more thing. As for now, the published After introducing DLLs, the "core" packages should be added as const ckeditor5Dependencies = {};
// Some operations on FS that will extract required packages and add those into `ckeditor5Dependencies` object.
require( '@ckeditor/ckeditor5-dev-env' )
.releaseSubRepositories( {
cwd: process.cwd(),
packages: 'packages',
customReleases: [ // Renamed from `emptyReleases`. It is an array of packages that should be modified before publishing.
'ckeditor5'
],
packageJsonForCustomReleases: { // An object that modifies the `package.json` for each package.
ckeditor5: {
dependencies: ckeditor5Dependencies
}
},
customReleasesFiles: {
ckeditor5: [ // An array of glob patterns. Files that match to those patterns will be released.
'src/*.js', // All JS files from the `src/` directory.
'dist/**' // Everything from the `dist/` directory.
]
},
dryRun: process.argv.includes( '--dry-run' )
} ); |
Related (build process): #8593. |
… "customReleases" that allows specifying which files from the original package should be copied. Introduced the `customReleasesFiles` option for the `releaseSubRepositories()` function. It allows specifying glob patterns of files that should be copied to the temporary directory from which the package will be published on npm. Closes [ckeditor/ckeditor5#8616](ckeditor/ckeditor5#8616). MAJOR BREAKING CHANGE (env): Renamed `options.packageJsonForEmptyReleases` to `options.packageJsonForCustomReleases` in the `releaseSubRepositories()` function. MAJOR BREAKING CHANGE (env): Renamed `options.emptyReleases` to `options.customReleases` in the `releaseSubRepositories()` function.
Provide a description of the task
As for now, the
ckeditor5
package is empty on npm.After closing #8395, we will have some source code in the package that should be released on npm.
We need to figure out what we would like to release and how much work it requires from us.
The text was updated successfully, but these errors were encountered: