Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo: paragraphs not restored when undoing image+text deletion #8870

Closed
scofalik opened this issue Jan 20, 2021 · 0 comments · Fixed by #8872
Closed

Undo: paragraphs not restored when undoing image+text deletion #8870

scofalik opened this issue Jan 20, 2021 · 0 comments · Fixed by #8872
Assignees
@scofalik
Labels
package:engine squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 40 (v26...

Comments

@scofalik
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Set data where you have a paragraph with text, an image, and some other paragraphs with text.
  2. Start removing data using backspace key from the end to the start.
  3. Try undoing all deletions.

✔️ Expected result

Final content after undo is as it was at the beginning.

❌ Actual result

All but one paragraph after an image are missing.

📃 Other details

Jan-20-2021.10-45-25.mp4
@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Jan 20, 2021
@scofalik scofalik changed the title Undo: paragraphs not restored when undoing text+image deletions Undo: paragraphs not restored when undoing image+text deletion Jan 20, 2021
@scofalik scofalik self-assigned this Jan 20, 2021
This was referenced Jan 20, 2021
Merged
Closed
@Mgsy Mgsy added this to the iteration 40 milestone Jan 25, 2021
@scofalik scofalik added the squad:collaboration Issue to be handled by the Collaboration team. label Feb 2, 2021
niegowski added a commit that referenced this issue Feb 2, 2021
@niegowski
Merge pull request #8872 from ckeditor/i/8870
385234a 
Fix (engine): Fixed content not restored on undo when multiple blocks and widgets were removed. Closes #8870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 40 (v26.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed content not restored on undo when multiple blocks and widgets were removed ckeditor/ckeditor5
2 participants
@scofalik @Mgsy