Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing accented letters (Spanish-ISO) fails in a link #888

Closed
Reinmar opened this issue Mar 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#189
Closed

Typing accented letters (Spanish-ISO) fails in a link #888

Reinmar opened this issue Mar 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#189
Assignees
@oleq
Labels
package:engine package:link package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 15

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 11, 2018 •
edited
Loading

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

lastest master

📋 Steps to reproduce

  1. Open http://localhost:8125/ckeditor5-core/tests/manual/article.html
  2. Change your keyboard to Spanish ISO
  3. Put selection in the middle of a link
  4. Type '' and then a`

✅ Expected result

You typed "á"

❎ Actual result

You typed "'a"

📃 Other details that might be useful

This worked in alpha.2. It stopped working due to the link highlight. It should work again after we switch from rendering link highlight as a span to rendering it is as a <a> element's class (which waits for ckeditor/ckeditor5-engine#1347 and is reported in https://github.com/ckeditor/ckeditor5-link/issues/180).
@Reinmar Reinmar added this to the iteration 15 milestone Mar 11, 2018
@Reinmar Reinmar modified the milestones: iteration 15, backlog Mar 30, 2018
@oleq oleq mentioned this issue Apr 4, 2018
Merged
@oleq oleq self-assigned this Apr 4, 2018
scofalik added a commit to ckeditor/ckeditor5-link that referenced this issue Apr 5, 2018
@scofalik
Merge pull request #189 from ckeditor/t/180
c75c4ca 
Fix: The selected link should be highlighted using the class instead of a marker. Closes #180. Closes #176. Closes ckeditor/ckeditor5#888.
@Reinmar Reinmar mentioned this issue Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:engine package:link package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 15
2 participants
@Reinmar @oleq