-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t/416: Improved responsiveness of the forms in narrow viewports #1299
Conversation
First of all with this PR I would recommend to add viewport settings in manual tests: |
I agree this is not perfect solution, but ATM we can live with it I guess. Anyway, I was thinking about something like mixin for buttons in the forms ( |
That's a good idea @dkonopka! It's way easier to tap. I added it in ckeditor/ckeditor5-theme-lark@33c974c. Oh, BTW, can you finish the review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Feature: Improved responsiveness of the forms in narrow viewports (see #416).
Suggested merge commit message (convention)
Feature: Improved responsiveness of the forms in narrow viewports (see #416).
Additional information
Things to decide
max-device-width
instead?