getSelectedBlocks() should ignore blocks where no content is selected
#13822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
force-pushed
the
ck/11585-fix-range-selection
branch
from
22df2ff to
f4d1628
Compare
filipsobol
force-pushed
the
ck/11585-fix-range-selection
branch
from
f4d1628 to
6d6b080
Compare
Reinmar
reviewed
Apr 5, 2023
Reinmar
reviewed
Apr 5, 2023
Corrected:
|
filipsobol
commented
Apr 5, 2023
filipsobol
force-pushed
the
ck/11585-fix-range-selection
branch
from
abad202 to
2b36cad
Compare
arkflpc
requested changes
Apr 5, 2023
arkflpc
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine):
Selection#getSelectedBlocks()should ignore trailing blocks where no content is selected. The selection of such blocks is not visible to the content author and is usually there unintentionally. Closes #11585.