Add paste from markdown experimental #15393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
changed the title
arkflpc
reviewed
Nov 23, 2023
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
niegowski
requested changes
Nov 23, 2023
packages/ckeditor5-markdown-gfm/docs/_snippets/features/paste-from-markdown.html
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/docs/_snippets/features/paste-from-markdown.js
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/docs/_snippets/features/paste-from-markdown.html
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/docs/features/paste-markdown.md
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
niegowski
requested changes
Nov 28, 2023
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
arkflpc
approved these changes
Nov 28, 2023
niegowski
requested changes
Nov 30, 2023
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-markdown-gfm/src/pastefrommarkdownexperimental.ts
Outdated
Show resolved
Hide resolved
…d not `DOMParser()`." This reverts commit 6c380b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (markdown-gfm): Added an experimental support for pasting from markdown. Closes #2321.
Additional information
This is an experimental implementation dedicated for further testing by the end user.
The tests provide 100% code coverage, but there are missing integration tests, and tests for different clipboard contents in Firefox, Edge and Safari.