Token should retry after refresh failure to avoid eventual client disconnection from the editing session #16890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
commented
Aug 8, 2024
| // If the refresh failed, keep trying to refresh the token. Failing to do so will eventually | ||
| // lead to the disconnection from the RTC service and the editing session (and potential data loss | ||
| // if the user keeps editing). | ||
| this._registerFailedRefreshTokenTimeout(); |
There was a problem hiding this comment.
I wonder if this should engage only when using the default refresh callback. A custom integrator's callback could come with its own refresh logic and this would be redundant or even buggy.
There was a problem hiding this comment.
I figured out that it's unlikely for a custom refresh callback to come with a retry logic and integrators who fall into this category should also benefit from auto-retry logic.
oleq
commented
Aug 8, 2024
DawidKossowski
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (cloud-services): The
Tokenrefresh should retry after failure to avoid disconnection and data loss in real-time collaboration.Additional information
Closes https://github.com/cksource/ckeditor5-commercial/issues/6561.