Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align translation tools to changes in ckeditor5-dev-* #17260

Merged
merged 42 commits into from
Oct 23, 2024
Merged

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Oct 14, 2024

Suggested merge commit message (convention)

Internal: Introduced translations:synchronize script to synchronize translations with language context files. Missing translations will be added, unused translations will be deleted, and missing translation files will be created.

Internal: Introduced translations:validate script to check the language context files against the translations. No files will be modified.

Internal: Introduced translations:move script to move requested translations between packages. It removes contexts and translated messages from language files ("*.po" files) from the source package and adds (or overwrites) them in the destination package.

Internal: Aligned to changes in ckeditor5-dev-*.

Internal: Fixed missing language contexts validation errors by moving "Paragraph" message from ckeditor5-heading to ckeditor5-core and "Color picker" from ckeditor5-table to ckeditor5-core.


Additional information

Part of https://github.com/cksource/ckeditor5-internal/issues/3825.

This PR requires:

@pomek
Copy link
Member

pomek commented Oct 21, 2024

replaceKebabCaseWithCamelCase - this helper is used thrice, and everywhere, it's duplicated. Could we create a generic util (./scripts/utils/?) and store it here?

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pomek and others added 11 commits October 22, 2024 10:27
Other (ui): Disabled dragging support for modal windows in the `Dialog` plugin. Closes #17290.

Other (ui): Disabled positioning restrictions for modal windows caused by `config.ui.viewportOffset`. Closes #17290.
Fix (ui): The dropdown menu component should not cause an editor blur if used in a `BalloonToolbar` while the user hovers a nested menu. Closes #17277.

Feature (utils): Made `FocusTracker` extendable with other `FocusTracker` instances to allow logical focus tracking across separate DOM sub-trees (see #17277)
Tests: Introduced automated manual test sample for performance testing and data sets to test on.
Internal (ui): Moved the document scroll lock for modal windows from `<body>` to `<html>` to make it bulletproof. Closes #17298.
@pomek pomek merged commit 0a65b8c into ci/epic/3789 Oct 23, 2024
7 checks passed
@pomek pomek deleted the ci/3825 branch October 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants