-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align translation tools to changes in ckeditor5-dev-*
#17260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…despite a pending blur timeout.
…ons with context files.
…ainst language context files.
…ated translation files.
…nt and handle its focus interactions.
…5-dev-translations` package.
…between packages.
Fix (ui): Made the page unscrollable while the modal is visible. Closes #17093.
|
pomek
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fix (ui): The dropdown menu component should not cause an editor blur if used in a `BalloonToolbar` while the user hovers a nested menu. Closes #17277. Feature (utils): Made `FocusTracker` extendable with other `FocusTracker` instances to allow logical focus tracking across separate DOM sub-trees (see #17277)
…<body> to <html> to make it bulletproof.
Tests: Introduced automated manual test sample for performance testing and data sets to test on.
Internal (ui): Moved the document scroll lock for modal windows from `<body>` to `<html>` to make it bulletproof. Closes #17298.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Introduced
translations:synchronize
script to synchronize translations with language context files. Missing translations will be added, unused translations will be deleted, and missing translation files will be created.Internal: Introduced
translations:validate
script to check the language context files against the translations. No files will be modified.Internal: Introduced
translations:move
script to move requested translations between packages. It removes contexts and translated messages from language files ("*.po" files) from the source package and adds (or overwrites) them in the destination package.Internal: Aligned to changes in
ckeditor5-dev-*
.Internal: Fixed missing language contexts validation errors by moving "Paragraph" message from
ckeditor5-heading
tockeditor5-core
and "Color picker" fromckeditor5-table
tockeditor5-core
.Additional information
Part of https://github.com/cksource/ckeditor5-internal/issues/3825.
This PR requires: