Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluded modal windows from the Classic editor's integration with dialogs #17341

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Excluded modal windows from the Classic editor's integration with dialogs #17341

merged 1 commit into from
Oct 29, 2024

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 28, 2024

Suggested merge commit message (convention)

Fix (editor-classic): Excluded modal windows from the Classic editor's integration between dialogs and the sticky toolbar. Closes #17339.

@f1ames f1ames self-requested a review October 29, 2024 12:46
f1ames
f1ames approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oleq oleq merged commit 3ef74d9 into master Oct 29, 2024
10 checks passed
@oleq oleq deleted the ck/17339 branch October 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1ames f1ames f1ames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classic editor's sticky toolbar dialog integration should ignore modals
2 participants
@oleq @f1ames