Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link properties/decorators view as a standalone form #17534

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Nov 26, 2024

Suggested merge commit message (convention)

Internal (link): Make link properties/decorators view a standalone form.


Additional information

Related issue #17230

It's part of improving linking experience initiative and implemented according to description in this comment.

standalone-link-form-2024-11-26_09.30.22.mp4

@Mati365 Mati365 marked this pull request as draft November 26, 2024 07:48
@Mati365 Mati365 force-pushed the ck/epic/17230-add-standalone-link-form branch 2 times, most recently from 915d066 to 6ff0d4a Compare November 26, 2024 09:50
@Mati365 Mati365 changed the base branch from ck/epic/17230-linking-experience to add-displayed-text November 26, 2024 09:50
@Mati365 Mati365 force-pushed the ck/epic/17230-add-standalone-link-form branch from f019901 to 31f9fcd Compare November 26, 2024 10:19
packages/ckeditor5-link/lang/contexts.json Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkediting.ts Show resolved Hide resolved
packages/ckeditor5-link/src/linkconfig.ts Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/ui/linkpropertiesview.ts Outdated Show resolved Hide resolved
@Mati365 Mati365 force-pushed the ck/epic/17230-add-standalone-link-form branch 2 times, most recently from 903c328 to 147b88c Compare November 26, 2024 11:59
@Mati365 Mati365 marked this pull request as ready for review November 26, 2024 12:59
@Mati365 Mati365 requested a review from niegowski November 26, 2024 13:04
@Mati365 Mati365 force-pushed the ck/epic/17230-add-standalone-link-form branch from 9dbddef to dfc2d5f Compare November 26, 2024 14:16
@Mati365 Mati365 requested a review from pszczesniak November 26, 2024 14:34
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/linkui.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/src/ui/linkpropertiesview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-link/tests/linkui.js Outdated Show resolved Hide resolved
scripts/clean-up-svg-icons.mjs Show resolved Hide resolved
@Mati365 Mati365 force-pushed the ck/epic/17230-add-standalone-link-form branch from 41662c2 to f17c9e9 Compare November 26, 2024 16:03
@Mati365 Mati365 requested a review from pszczesniak November 27, 2024 08:04
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks ok 👍

@Mati365 Mati365 merged commit 944ab1e into add-displayed-text Nov 27, 2024
7 checks passed
@Mati365 Mati365 deleted the ck/epic/17230-add-standalone-link-form branch November 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants