Fix: Nested editable. #17809
Merged
Fix: Nested editable. #17809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorzelinski
requested review from
arkflpc,
Mati365 and
niegowski
and removed request for
Mati365
gorzelinski
commented
Jan 24, 2025
pszczesniak
requested changes
Jan 27, 2025
I fixed the solution with the help of Kuba, and I am working on it :) |
|
The added test passes, but it's probably a false positive. I feel like I did something wrong with emulating clicking backspace, but I'm unsure what. It doesn't help that I found many ways to do that in our tests. Could you take a look in your free time? @pszczesniak |
niegowski
reviewed
Feb 13, 2025
niegowski
requested changes
Feb 18, 2025
Mati365
previously approved these changes
Feb 18, 2025
pszczesniak
previously approved these changes
Feb 19, 2025
gorzelinski
dismissed stale reviews from pszczesniak and Mati365
via
f27c9a3
Mati365
approved these changes
Feb 19, 2025
niegowski
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Nested editable. Closes #17383.
Additional information
It fixes deleting nested editables on all browsers with an edge case on Safari (deleting whole lines).
For example – encountered issues, assumptions you had to make, other affected tickets, etc.