-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T/1945: Bumped style-loader to v1.0.0. Aligned configurations and documentation to the new loader API #1949
Conversation
Docs: Set dependency versions, to avoid installing their new major versions.
I checked that there are far more dependencies that we can upgrade in builds now: "postcss-loader": "^3.0.0",
- "raw-loader": "^1.0.0",
- "style-loader": "^0.23.0",
- "uglifyjs-webpack-plugin": "^1.2.7",
- "webpack": "^4.15.0",
- "webpack-cli": "^3.0.8"
+ "raw-loader": "^3.1.0",
+ "style-loader": "^1.0.0",
+ "uglifyjs-webpack-plugin": "^2.2.0",
+ "webpack": "^4.39.1",
+ "webpack-cli": "^3.3.6"
}, I'd upgrade all at once. Also, as long as we don't force you to make them, they are not breaking. E.g. you only need to change your webpack config if you bumped style-loader in your package.json and this is your call. So, if this is the same situation with all the other pkgs, then we can safely do it even now. So todo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented.
I bumped other deps up. The thing with the uglify plugin is that we cannot go to 2.0 because it's not es6 compatible. We'd have to use terser.
Other than that, things look like they're working (raw–loader in particular). |
Suggested merge commit message (convention)
Other: Bumped style-loader to v1.0.0. Aligned configurations and documentation to the new loader API. Closes #1945.
BREAKING CHANGE: The entire project migrated to style-loader v1.0.0 which has a different configuration syntax. Make sure your webpack configuration files are up–to–date to avoid future errors.
Additional information
This PR requires other PRs: