Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Improved RWD of demos in Examples section #5609

Merged
merged 3 commits into from
Oct 17, 2019
Merged

[Docs] Improved RWD of demos in Examples section #5609

merged 3 commits into from
Oct 17, 2019

Conversation

dkonopka
Copy link
Contributor

@dkonopka dkonopka commented Oct 17, 2019

Suggested merge commit message (convention)

Docs: Improved RWD of demos in the Examples section. Closes #5598.


Additional information

  1. Enlarged container width of document editor demo

Screenshot 2019-10-17 at 10 48 03

  1. Fixed document editor demo for mobiles because ATM it looks like this:

Before:
Screenshot 2019-10-17 at 10 24 28

@dkonopka dkonopka requested a review from oleq October 17, 2019 08:46
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better but there's still some weird movement at some point

Kapture 2019-10-17 at 11 15 50

@Reinmar
Copy link
Member

Reinmar commented Oct 17, 2019

Enlarged container width of document editor demo

Could we keep the textual content limited to some max-width there? So only the editor stretches? I think that this is the only demo where we need something like this, so it can be hardcoded there, I guess...

@oleq
Copy link
Member

oleq commented Oct 17, 2019

Could we keep the textual content limited to some max-width there?

I'm confused. Isn't it exactly what Damian did below?

Screenshot 2019-10-17 at 10 48 03

@dkonopka
Copy link
Contributor Author

I'm confused. Isn't it exactly what Damian did below?

@Reinmar means title & paragraph above the editor. But it's not easiest thing to do, because we can't "catch" these elements easily...

.main__content-inner .main__content-title,
.main__content-inner > p {
  max-width: some-number;
}

Screenshot 2019-10-17 at 11 26 59

@dkonopka
Copy link
Contributor Author

@Reinmar I'm not so sure about this change:

Screenshot 2019-10-17 at 11 37 38

@oleq oleq merged commit 6a869ff into master Oct 17, 2019
@oleq oleq deleted the i/5598 branch October 17, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RWD of the examples gives strange results
3 participants