Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i/353: Focus the editor before executing a command #6066

Merged
merged 1 commit into from
Jan 28, 2020
Merged

i/353: Focus the editor before executing a command #6066

merged 1 commit into from
Jan 28, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Jan 13, 2020

Suggested merge commit message (convention)

Fix: Focus the editor before executing toolbar buttons' command. Closes #353.

@Reinmar Reinmar removed the pr:sub label Jan 21, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 21, 2020

I checked all the PRs and they do the job. Some features are still not covered and need to be checked: e.g. lists, alignment, code blocks.

Reinmar
Reinmar requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.

This was referenced Jan 28, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@panr
Copy link
Contributor Author

panr commented Jan 28, 2020 •
edited
Loading

Ok, it looks like only list hasn't had the fix. Alignment and code blocks works. I had to close one of the PR (link - ckeditor/ckeditor5-link#254 (comment)) where I broke the feature instead of fixing it ¯_(ツ)_/¯

I also changed references in each PR to target this master PR, not the issue.

@panr panr requested a review from Reinmar January 28, 2020 15:16
@Reinmar Reinmar merged commit 0d0505f into master Jan 28, 2020
@Reinmar Reinmar deleted the i/353 branch January 28, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reinmar Reinmar Awaiting requested review from Reinmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All buttons should focus the editor before executing their commands
2 participants
@panr @Reinmar