#6693: Keyboard support for the widget type around feature #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed" range is the same as the original.
… faster feedback and better UX when navigating the document.
…e regular caret disappears and so should the fake one.
…on dark backgrounds.
…ause they are used in WidgetTypeAround now.
…"from the outside".
…et the new selection if no range was "post-fixed".
… part of the Widget plugin to the WidgetTypeAround plugin.
…d a widget using the keyboard.
…g the fake caret mode.
…d.js Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
…o shorter sub-methods.
niegowski
reviewed
Jun 9, 2020
packages/ckeditor5-widget/tests/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
@FilipTokarski I checked this on CKEditor 5 master and it's the same. The change is not related to this PR. Can you please confirm this? |
…ty elements precede or follow a widget.
…nal masks in isNonTypingKeystroke() tests.
…ypeAround fake caret.
|
🤔 True. IDK what happened, but you are right. The PR is 👍 |
…el element instead of a view element.
…e around classes instead of a view widget element.
… listeners for more flexibility when integrating with other features (TableKeyboard, WidgetTypeAround).
|
More review frenzy please, @niegowski. |
niegowski
reviewed
Jun 10, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
niegowski
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): The model selection post-fixer should not set a new selection if the ranges before and after post-fixing are the same (see #6693).
Tests (image): Aligned image tests to the latest
WidgetTypeAroundplugin API (see #6693).Other (paragraph): The
InsertParagraphCommandshould split ancestors of thePositionto find a parent that allows'paragraph'(see #6693).Tests (table): Aligned
Tableplugin tests to the latestWidgetTypeAroundAPI. Code refactoring (see #6693).Feature (theme-lark): Added styles for a "fake caret" brought by the
WidgetTypeAroundplugin (see #6693).Feature (typing): Created a public
isNonTypingKeystroke()helper (see #6693).Feature (utils): Created
isArrowKeyCode(),getLocalizedArrowKeyCodeDirection(), andisForwardArrowKeyCode()helpers (see #6693).Feature (widget): Implemented keyboard support for inserting paragraphs around block widgets using a "fake horizontal caret" (
WidgetTypeAround). Both "Insert new paragraph" buttons are now always displayed for all block widgets regardless of their location in the document. Closes #6693. Closes #6825. Closes #6694.Also:
Widgetplugin,Widgettests to the newWidgetTypeAroundkeyboard behavior,EnterandShift+Entersupport from theWidgetplugin to theWidgetTypeAroundplugin.MINOR BREAKING CHANGE (widget): Removed the
getWidgetTypeAroundPositions()helper since the "Insert new paragraph" buttons are now visible regardless of the widget location in the document.Additional information
@ckeditor/qa-team Can you take a look at this new feature? It supports arrow keys and enter/backspace/typing when a "fake caret" is displayed (no paste support yet).