Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7360: Downcast conversion for markers over table cells #7391

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Other (table): Markers on the table cells should be visible on the cell level, not only on the cell content. Closes #7360.


Additional information

@oleq
Copy link
Member

oleq commented Jun 8, 2020

A follow-up #7401.

@oleq
Copy link
Member

oleq commented Jun 9, 2020

@scofalik I assume this is to enable cell properties in TC. Is there any way to test it? I tried the TC manual test but there's no support for cell properties on master yet.

@niegowski
Copy link
Contributor Author

@scofalik I assume this is to enable cell properties in TC. Is there any way to test it? I tried the TC manual test but there's no support for cell properties on master yet.

I was testing it here: http://localhost:8125/ckeditor5-engine/tests/manual/highlight.html

@oleq oleq merged commit 48d80cb into master Jun 9, 2020
@oleq oleq deleted the i/7360 branch June 9, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide marker conversion handling for table cells
3 participants