Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Feature (engine): Added model Position#findAncestor() and Element#findAncestor() methods. Closes #3233.

Internal (table): Removed findAncestor helper.

MINOR BREAKING CHANGE (table): The findAncestor() utility function was removed.


Additional information

@niegowski niegowski requested a review from jodator July 9, 2020 16:16
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about using element.is() after a second thought I don't see that needed and name === parentName is OK for me, WDYT?

@jodator jodator merged commit a349af5 into master Jul 13, 2020
@jodator jodator deleted the i/3233 branch July 13, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TableUtils#getTable()
2 participants