I/7579: Allow disabling image resize handles #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dResizerThrottled()` callback.
|
I don't get it. Locally everything is 🟢 🤔 (all tests and |
There was dev-tools update AFAIR and Kamil might be working on it. |
jodator
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
Some minor things to cover. I'm also unsure what to do with another configuration option - but let's wait with this for (#7579 (comment) answer).
packages/ckeditor5-image/tests/imageresize/imageresizehandles.js
Outdated
Show resolved
Hide resolved
|
@panr unfrotunately, please remove the config option. It's easier to add it later then removed unused ones. If something is doable by adding/removing plugins we prefer that over a configuration. |
|
I fixed all the minor things. Still don't know how to fix/change the test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (image): Allow to configure
ImageResizein a more granular way. For example, by combiningImageResizeEditingwithImageResizeHandlesorImageResizeUIto resize image by handles or by image toolbar UI components (dropdown or standalone buttons) respectively. Closes #7579.Docs (image): Add a new section to feature documentation for the
Imageplugin about disabling image resize handles.Internal (image): Separate
ImageResizeHandlesplugin from theImageResizeEditing.Tests (image): Refactor unit tests for
ImageResizeHandlesandImageResizeEditing.