Fixed incorrect selection fixing in some multi-cell selection scenarios #7662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
commented
Jul 21, 2020
|
|
||
| // If nearest valid selection range has been found - add it in the place of old range. | ||
| // If range is equal to any other selection ranges then it is probably due to contents | ||
| // of a multi-range selection being removed. See ckeditor/ckeditor5#6501. | ||
| if ( selectionRange && !isRangeCollidingWithSelection( selectionRange, this ) ) { |
There was a problem hiding this comment.
An explanation behind removing isRangeCollidingWithSelection: after the changes I propose, the selection can be fixed only if there are no ranges in it, so there is no possibility that there would be any collision. This is also the reason why splice is gone -- I've changed the flow a little and now the range is deleted from selection when it is detected that it was removed from the content. So at this moment, there's no need to remove anything, we just need to add the new range.
There was a problem hiding this comment.
I like how this get simplified.
scofalik
commented
Jul 21, 2020
niegowski
approved these changes
Jul 21, 2020
jodator
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Fixed incorrect selection fixing in some multi-cell selection scenarios. Closes #7659.