Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7633: Resizer#redraw() should not change the editing view unless a different size should be set #7664

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Jul 21, 2020

Suggested merge commit message (convention)

Fix: Resizer#redraw() should not change the editing view unless a different size should be set. Closes #7633.

@oleq oleq requested a review from mlewand July 21, 2020 13:51
@oleq
Copy link
Member Author

oleq commented Jul 21, 2020

The glitch should be gone now.

@oleq
Copy link
Member Author

oleq commented Jul 21, 2020

FYI: #7548 is a different problem.

@Reinmar Reinmar requested review from Reinmar and removed request for mlewand July 22, 2020 06:10
@Reinmar
Copy link
Member

Reinmar commented Jul 22, 2020

The PR looks good to me and I'd be completely fine to merge it but what I described in #7548 (comment) worries me. Why two similar issues appeared so close one another? What's causing the paste/upload glitch? I have a feeling that there's something wrong elsewhere and that a fix for that thing may fix both issues.

Still, I'll be ok with merging this PR, but after we check whether a fix for the other bug will not resolve this too (if we merge this PR it won't be that easy to check).

@oleq
Copy link
Member Author

oleq commented Jul 22, 2020

I couldn't reproduce the upload/paste glitch and I asked the issue author for more details

In the meantime, this PR addresses not only the resizer glitch issue but also fixes the nasty View#render() loop when an image is selected, which could have other unidentified consequences in the editor.

@Reinmar Reinmar merged commit 978dd71 into master Jul 22, 2020
@Reinmar Reinmar deleted the i/7633-resizer-glitch branch July 22, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blue border glitch when undoing image resize
2 participants