Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection stops searching for attributes when spotted an inline element #7714

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented Jul 27, 2020

Suggested merge commit message (convention)

Fix (engine): Selection will not inherit attributes if spotted an inline element while searching for a node from which attributes could be copied. Closes #7459.

Tests (enter): Added an integration test that covers a bug with copying attributes from a node before an inline element. See #7459.

…le searching for a node from which attributes could be copied.
@pomek pomek requested a review from jodator July 27, 2020 07:38
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@jodator jodator merged commit 1ddb955 into master Jul 27, 2020
@jodator jodator deleted the i/7459 branch July 27, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected type with link on keyboard move
2 participants