-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix z-index for the toolbar dropdown panels. #7893
Conversation
@oleq @Mgsy @FilipTokarski could you take a look at this? |
priority is 📈 |
I was about to point it out. Unfortunately this is inevitable because the floating toolbar has But, the drawback of lesser z-index is that no matter what, there's no way to make the panel located in the floating toolbar display over the contextual balloon (like in the screenshot). CSS works on layers and if layer A (floating toolbar) has lesser |
… be used again somewhere else because it is too specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with the change and we can merge it when @Mgsy gives it a green light.
We've tested it with @FilipTokarski and looks good 👌 |
Suggested merge commit message (convention)
Fix (ui): Dropdown panels from the editor's main toolbar should be always above the contextual balloons from the editor's content. Closes #7874.