Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index for the toolbar dropdown panels. #7893

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Fix z-index for the toolbar dropdown panels. #7893

merged 3 commits into from
Aug 21, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Aug 21, 2020

Suggested merge commit message (convention)

Fix (ui): Dropdown panels from the editor's main toolbar should be always above the contextual balloons from the editor's content. Closes #7874.

@panr
Copy link
Contributor Author

panr commented Aug 21, 2020

@oleq @Mgsy @FilipTokarski could you take a look at this?

@panr
Copy link
Contributor Author

panr commented Aug 21, 2020

priority is 📈

@oleq oleq self-requested a review August 21, 2020 09:06
@oleq oleq self-assigned this Aug 21, 2020
@Mgsy
Copy link
Member

Mgsy commented Aug 21, 2020

Is the floating toolbar in the scope of this PR? Currently, dropdown panels are displayed under the contextual balloons from the content after scrolling down a bit (the screen below shows the classic editor).

@oleq
Copy link
Member

oleq commented Aug 21, 2020

Is the floating toolbar in the scope of this PR? Currently, dropdown panels are displayed under the contextual balloons from the content after scrolling down a bit.

I was about to point it out. Unfortunately this is inevitable because the floating toolbar has position: fixed. As a whole it must have lesser z-index than contextual balloons because they have the priority (floating toolbar vs. contextual toolbar) so, for instance, the table toolbar does not disappear under the floating toolbar. 

But, the drawback of lesser z-index is that no matter what, there's no way to make the panel located in the floating toolbar display over the contextual balloon (like in the screenshot). CSS works on layers and if layer A (floating toolbar) has lesser z-index than layer B (contextual toolbar), then no matter how high the z-index of the panel (living inside layer A) is, it is still limited to the z-index of the entire layer A.

… be used again somewhere else because it is too specific.
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the change and we can merge it when @Mgsy gives it a green light.

@Mgsy
Copy link
Member

Mgsy commented Aug 21, 2020

We've tested it with @FilipTokarski and looks good 👌

@oleq oleq merged commit 57d3f02 into master Aug 21, 2020
@oleq oleq deleted the i/7874 branch August 21, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contextual balloon appears above the balloon from the main toolbar
3 participants