Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code should not be copied to a new line on Enter #8408

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Code should not be copied to a new line on Enter #8408

merged 1 commit into from
Nov 4, 2020

Conversation

pkwasnik
Copy link
Contributor

@pkwasnik pkwasnik commented Nov 3, 2020

Suggested merge commit message (convention)

Fix (basic-styles): Code should not be copied to a new line on Enter. Closes #8144.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pkwasnik pkwasnik requested a review from jodator November 3, 2020 12:51
jodator
jodator approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering for a brief time if we shouldn't add behavioral tests for this case but AFAICS we don't have such tests in other basic styles features. I think we can live with this. Also, the copyOnEnter should have tests for this behaviour already.

@jodator jodator merged commit 000aeb6 into master Nov 4, 2020
@jodator jodator deleted the i/8144 branch November 4, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code should not be copied to a new line on Enter
2 participants
@pkwasnik @jodator