Fix (indent): blockIndent now works with custom headings. Closes #8177. #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Hi @antoniolucasnobar, thanks for a great PR!
We really appreciate PRs with tests :)
I've added some additions to the PR just to have those covered in the manual tests - mostly used by the CKEditor 5 team.
I was thinking about removing the || since the configuration option should be always present but we do allow implementing the own heading plugin, so in theory, it could be that heading.options will not be defined.
Big thanks!
ps.: Bonus points for using fancy heading as it was my favorite addition to the docs :D
|
BTW, I've fixed the headings demo: 12b1732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix (indent): blockIndent now works with custom headings. Closes #8177.
Additional information
Please let me know if you want me to change anything.