Added support for RTL in html-embed. #8535
Conversation
There was a problem hiding this comment.
There's also one thing not covered by this PR: These styles should not work in RTL because the embed label is on the other side and we don't need to compensate for it.
Actual:
Expected:
| @@ -118,3 +122,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| .ck-content[dir="rtl"] .ck-widget.raw-html-embed { | |||
There was a problem hiding this comment.
These are not content styles and they should not start with .ck-content. Both the label and the buttons wrapper are not in the editor output data and the styles should not be listed in the guide.
I think this should be done using @mixin ck-dir rtl { ... }.
| @@ -117,3 +117,21 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .ck[dir="rtl"] .ck.ck-tooltip { | |||
There was a problem hiding this comment.
This should not be handled in CSS like this. Instead, this should be done at the JS level based on locale.uiLanguageDirection (locale.uiLanguageDirection === 'rtl' ? 'se' : 'sw'). To do that we need a new .ck-tooltip_se style corresponding to the existing .ck-tooltip_sw and documented in the TooltipView#position property docs.
Edit: Not sure if locale.contentLanguageDirection makes more sense than locale.uiLanguageDirection. Take a look at https://ckeditor.com/docs/ckeditor5/latest/features/ui-language.html#setting-the-language-of-the-content before making the decision 😛
Suggested merge commit message (convention)
Fix (html-embed): HTML embed editing UI should not be broken when the editor uses an RTL language. Closes #8335.
Fix (theme-lark): HTML embed editing UI should not be broken when the editor uses an RTL language.
Feature (ui): Added support for a new south-east position of the
TooltipView.Feature (theme-lark): Added styles for a new south-east position of the
TooltipView.Additional information