Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dll integration #8614

Merged
merged 244 commits into from
Feb 1, 2021
Merged

Dll integration #8614

merged 244 commits into from
Feb 1, 2021

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Dec 9, 2020

Suggested merge commit message (convention)

Other: Enabled creating builds that can be extended (with more plugins) without the need to being recompiled. This required splitting the project into the, so-called, DLL part and consumers of this DLL. Under the hood, the mechanism is based on webpack DLLs. This is the first part of the required changes and it contains the necessary breaking changes (see the "MAJOR BREAKING CHANGES" section above). For more information see the "DLL builds" guide. Closes #8395.

Other: Introduced Image.isImageWidget() utility method.

Feature (core): Plugin collection will allow to require plugin by name when it is provided in config.plugins or if it was already loaded. Closes #2907.

MAJOR BREAKING CHANGE: Several plugins are not anymore loaded automatically as dependencies of other plugins. From now on, they need to be provided to the editor creator manually (via config.plugins). This list includes:

  • The CloudServicesUploadAdapter plugin no longer loads CloudServices. Make sure to add CloudServices to the editor plugins when using the  CloudServicesUploadAdapter or EasyImage features.
  • The EasyImage plugin no longer loads Image and ImageUpload. Make sure to add Image and ImageUpload to the editor plugins when using the EasyImage feature.
  • The CKFinder plugin no longer loads CKFinderUploadAdapter. The CKFinderEditing plugin no longer loads ImageEditing and LinkEditing features. Make sure to add CKFinderUploadAdapterImage, and Link features to the editor plugins when using the CKFinder feature.
  • The Title plugin no longer loads Paragraph. Make sure to add Paragraph to the editor plugins when using the Title feature.
  • The ListEditing plugin no longer loads Paragraph. Make sure to add Paragraph to the editor plugins when using the List feature.
  • The LinkImageEditing plugin no longer loads ImageEditing. Make sure to add Image to the editor plugins when using the LinkImage feature.
  • The LinkImageUI plugin no longer loads Image. Make sure to add Image to the editor plugins when using the LinkImage feature.

Additional information

This going to be a huge PR but already reviewed. Let's keep merge notes here as I see that many of the changes might get lost.

Requires: ckeditor/ckeditor5-dev#683.

jodator and others added 30 commits November 4, 2020 14:20
Reinmar and others added 28 commits January 12, 2021 14:32
Internal: Updated import paths. See #8581.
Internal: Do not log plugin errors thrown in initialization phase twice. Closes #8680.
@Reinmar Reinmar merged commit b278fde into master Feb 1, 2021
@Reinmar Reinmar deleted the dll-integration branch February 1, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants