-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dll integration #8614
Merged
Merged
Dll integration #8614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Enabled creating builds that can be extended (with more plugins) without the need to being recompiled. This required splitting the project into the, so-called, DLL part and consumers of this DLL. Under the hood, the mechanism is based on webpack DLLs. This is the first part of the required changes and it contains the necessary breaking changes (see the "MAJOR BREAKING CHANGES" section above). For more information see the "DLL builds" guide. Closes #8395.
Other: Introduced
Image.isImageWidget()
utility method.Feature (core): Plugin collection will allow to require plugin by name when it is provided in
config.plugins
or if it was already loaded. Closes #2907.MAJOR BREAKING CHANGE: Several plugins are not anymore loaded automatically as dependencies of other plugins. From now on, they need to be provided to the editor creator manually (via
config.plugins
). This list includes:CloudServicesUploadAdapter
plugin no longer loadsCloudServices
. Make sure to addCloudServices
to the editor plugins when using theCloudServicesUploadAdapter
orEasyImage
features.EasyImage
plugin no longer loadsImage
andImageUpload
. Make sure to addImage
andImageUpload
to the editor plugins when using theEasyImage
feature.CKFinder
plugin no longer loadsCKFinderUploadAdapter
. TheCKFinderEditing
plugin no longer loadsImageEditing
andLinkEditing
features. Make sure to addCKFinderUploadAdapter
,Image
, andLink
features to the editor plugins when using theCKFinder
feature.Title
plugin no longer loadsParagraph
. Make sure to addParagraph
to the editor plugins when using theTitle
feature.ListEditing
plugin no longer loadsParagraph
. Make sure to addParagraph
to the editor plugins when using theList
feature.LinkImageEditing
plugin no longer loadsImageEditing
. Make sure to addImage
to the editor plugins when using theLinkImage
feature.LinkImageUI
plugin no longer loadsImage
. Make sure to addImage
to the editor plugins when using theLinkImage
feature.Additional information
This going to be a huge PR but already reviewed. Let's keep merge notes here as I see that many of the changes might get lost.
Requires: ckeditor/ckeditor5-dev#683.