Add support for the config.forceValue option in ListCommand
#9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s overriding the default toggle-like behavior.
scofalik
requested changes
Mar 29, 2021
| @@ -133,6 +133,33 @@ describe( 'ListCommand', () => { | |||
| } ); | |||
| } ); | |||
|
|
|||
| describe( 'options.forceValue', () => { | |||
There was a problem hiding this comment.
I'd make tests showing that lisItem with forceValue true does not change anything, and similarly for paragraphs and false. AFAICS, these tests describe "normal" behavior.
There was a problem hiding this comment.
There are two assertions for each test to check both scenarios. But I can simplify these tests and split the 4 assertions into 4 tests.
There was a problem hiding this comment.
🤦 let's say it was late when I was reviewing
Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Introduced the
config.forceValueoption toListCommandthat allows overriding the default toggle-like behavior to allow more predictable state changes during applying track changes suggestions.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.