The table should not save the caption in the model attribute #9590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbarnas
force-pushed
the
i/9543-table-caption-storage
branch
from
03373f5 to
6c797b9
Compare
niegowski
reviewed
May 5, 2021
packages/ckeditor5-table/src/tablecaption/tablecaptionediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/src/tablecaption/tablecaptionediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/src/tablecaption/tablecaptionediting.js
Outdated
Show resolved
Hide resolved
Comment on lines
282
to
291
| setData( model, | ||
| '<table>' + | ||
| '<tableRow>' + | ||
| '<tableCell>' + | ||
| '<paragraph></paragraph>' + | ||
| '</tableCell>' + | ||
| '</tableRow>' + | ||
| '<caption></caption>' + | ||
| '</table>' | ||
| ); |
There was a problem hiding this comment.
This would override the model and the original issue would not happen. You should modify the model by removing the caption content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): The table should not save the caption in the model attribute to prevent issues in collaboration. Closes #9543.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.