Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the default table cell properties #9610

Merged
merged 10 commits into from
May 5, 2021

Conversation

pomek
Copy link
Member

@pomek pomek commented May 2, 2021

Suggested merge commit message (convention)

Feature (table): Support for the default table cell properties.

MINOR BREAKING CHANGE (table): Clases TableCellHorizontalAlignmentCommand, TableCellVerticalAlignmentCommand, TableCellBackgroundColorCommand, TableCellBorderColorCommand, TableCellBorderStyleCommand, TableCellBorderWidthCommand, TableCellHeightCommand, TableCellPropertyCommand, TableCellWidthCommand, TableCellPaddingCommand require the second argument called defaultValue which is the default value for the command.

MINOR BREAKING CHANGE (table): The TableCellPropertiesView class requires additional property in the object as the second constructor argument (options.defaultTableCellProperties).

MINOR BREAKING CHANGE (table): The upcastBorderStyles() helper for conversion requires the third argument called defaultBorder. An object that defines default border (width, color, style) definitions.


Additional information

All changes based on .#9555

@pomek pomek requested a review from niegowski May 2, 2021 15:08
@niegowski niegowski merged commit 37f1699 into master May 5, 2021
@niegowski niegowski deleted the table-cell-default-properties branch May 5, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants