Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change marker-to-data logic to improve conversion inside document fragment #9624

Merged
merged 4 commits into from
May 5, 2021
Merged

Change marker-to-data logic to improve conversion inside document fragment #9624

merged 4 commits into from
May 5, 2021

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented May 4, 2021

Suggested merge commit message (convention)

Other (engine): In marker-to-data conversion, attributes for marker boundaries will be used every time the marker starts or ends before or after a model element, instead only where text is not allowed by model schema. Closes #9622.

scofalik and others added 3 commits May 4, 2021 17:11
@scofalik
Docs: Fixed some outdated docs in model.TreeWalker.
938c1d9
@scofalik
Other (engine): In marker-to-data conversion, attributes for marker b…
220232a 
…oundaries will be used every time the marker starts or ends before or after a model elements, instead only where text is not allowed by model schema.
@niegowski
Updated code comment.
aa5c6b4
@scofalik
Copy link
Contributor Author

scofalik commented May 5, 2021

Or it could be

[<elementAfter>...</elementAfter> -> <elementAfter data-group-start-before="...">...</elementAfter>
<parent>]<elementAfter> -> <parent>]<elementAfter data-group-end-before="...">
<elementBefore>...</elementBefore>] -> <elementBefore data-group-end-after="...">...</elementBefore>
</elementBefore>[</parent> -> </elementBefore data-group-start-after="..."></parent>

@niegowski niegowski merged commit 36b685c into master May 5, 2021
@niegowski niegowski deleted the i/9622 branch May 5, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niegowski niegowski niegowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change marker-to-data logic to improve conversion inside document fragment
2 participants
@scofalik @niegowski