Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pulling changes from the root repository when using mrgit #160

Closed
pomek opened this issue Jul 26, 2023 · 0 comments · Fixed by #162
Closed

Allow pulling changes from the root repository when using mrgit #160

pomek opened this issue Jul 26, 2023 · 0 comments · Fixed by #162
Assignees
Labels
squad:platform Issue to be handled by the Platform team. type:enhancement
Milestone

Comments

@pomek
Copy link
Member

pomek commented Jul 26, 2023

📝 Provide a description of the improvement

Right now, many of us execute the following commands to update an environment:

git pull
mrgit sync

Wouldn't it be useful to execute git pull in the root repository (where the mrgit.json file exists)?

By default, this behavior would be disabled. To enable the extra feature, we should extend the configuration. Example:

{
	"packages": "external/",
	"$rootRepository": "ckeditor/ckeditor5#master",
	"dependencies": {
		/* ... */
	},
	"presets": {
		"release": {
			"$rootRepository": "ckeditor/ckeditor5#release"
			/* ... */
		}
	}
}

Extra point: figure out how to combine the $rootRepository with presets.

The name of the option is a subject to discuss.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@pomek pomek added type:enhancement squad:platform Issue to be handled by the Platform team. labels Jul 26, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 16, 2023
@przemyslaw-zan przemyslaw-zan self-assigned this Aug 16, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 16, 2023
pomek added a commit that referenced this issue Aug 25, 2023
Feature: Added support for executing commands in the root repository. Closes #160.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 25, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:platform Issue to be handled by the Platform team. type:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants