Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smt generation and solving #38

Merged
merged 1 commit into from
Sep 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 54 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ clap = "3.0.0-beta.1"
riscv-decode = { git = "https://github.com/cksystemsgroup/riscv-decode" }
petgraph = "0.5.1"
rand = "0.7.3"
boolector = { version = "0.4", git = "https://github.com/finga/boolector-rs", branch = "boolector-src", features = ["vendored"] }

[dev-dependencies]
serial_test = "0.4.0"
Expand Down
1 change: 1 addition & 0 deletions src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ pub fn args() -> App<'static> {
.default_value("dot"),
),
)
.subcommand(App::new("smt"))
.setting(AppSettings::SubcommandRequiredElseHelp)
.global_setting(AppSettings::GlobalVersion)
}
92 changes: 46 additions & 46 deletions src/formula_graph.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
use crate::cfg::ControlFlowGraph;
use crate::elf::ElfMetadata;
use crate::iterator::ForEachUntilSome;
use byteorder::{ByteOrder, LittleEndian};
use core::fmt;
pub use petgraph::graph::NodeIndex;
use petgraph::visit::EdgeRef;
use petgraph::Graph;
use riscv_decode::types::*;
use riscv_decode::Instruction;
Expand Down Expand Up @@ -126,7 +128,7 @@ impl fmt::Debug for Input {
}

#[allow(dead_code)]
#[derive(Clone, Eq, Hash, PartialEq)]
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)]
pub enum BooleanFunction {
NotEqual,
Equals,
Expand Down Expand Up @@ -604,7 +606,7 @@ fn sign_extend_itype_stype(imm: u32) -> u64 {
}

#[allow(dead_code)]
fn build_dataflow_graph(
pub fn build_dataflow_graph(
path: &[Instruction],
data_segment: &[u8],
elf_metadata: ElfMetadata,
Expand All @@ -614,64 +616,62 @@ fn build_dataflow_graph(
.generate_graph()
}

// Returns a path of RISC-U instructions and branch decisions (if true or false branch has been taken)
// for a path with 1 BEQ instruction, the vector of branch decisions has the length of 1
pub fn extract_candidate_path(graph: &ControlFlowGraph) -> (Vec<Instruction>, Vec<bool>) {
fn next(graph: &ControlFlowGraph, idx: NodeIndex) -> Option<(NodeIndex, Option<bool>)> {
let edges = graph.edges(idx);

if let Some(edge) = edges.last() {
let target = edge.target();

match graph[idx] {
Instruction::Beq(_) => {
let next_idx = edge.target().index();

if next_idx == idx.index() + 1 {
Some((target, Some(false)))
} else {
Some((target, Some(true)))
}
}
_ => Some((target, None)),
}
} else {
None
}
}
let mut path = vec![];
let mut branch_decisions = vec![];
let mut idx = graph.node_indices().next().unwrap();
path.push(idx);
while let Some(n) = next(graph, idx) {
path.push(n.0);
idx = n.0;

if let Some(branch_decision) = n.1 {
branch_decisions.push(branch_decision);
}
}
let instruction_path = path.iter().map(|idx| graph[*idx]).collect();

(instruction_path, branch_decisions)
}

// TODO: need to load data segment => then write test
#[cfg(test)]
mod tests {
use super::*;
use crate::cfg;
use crate::cfg::ControlFlowGraph;
use crate::dead_code_elimination::eliminate_dead_code;
use petgraph::dot::Dot;
use petgraph::visit::EdgeRef;
use serial_test::serial;
use std::env::current_dir;
use std::fs::File;
use std::io::prelude::*;
use std::path::Path;
use std::process::Command;

// Returns a path of RISC-U instructions and branch decisions (if true or false branch has been taken)
// for a path with 1 BEQ instruction, the vector of branch decisions has the length of 1
pub fn extract_candidate_path(graph: &ControlFlowGraph) -> (Vec<Instruction>, Vec<bool>) {
fn next(graph: &ControlFlowGraph, idx: NodeIndex) -> Option<(NodeIndex, Option<bool>)> {
let edges = graph.edges(idx);

if let Some(edge) = edges.last() {
let target = edge.target();

match graph[idx] {
Instruction::Beq(_) => {
let next_idx = edge.target().index();

if next_idx == idx.index() + 1 {
Some((target, Some(false)))
} else {
Some((target, Some(true)))
}
}
_ => Some((target, None)),
}
} else {
None
}
}
let mut path = vec![];
let mut branch_decisions = vec![];
let mut idx = graph.node_indices().next().unwrap();
path.push(idx);
while let Some(n) = next(graph, idx) {
path.push(n.0);
idx = n.0;

if let Some(branch_decision) = n.1 {
branch_decisions.push(branch_decision);
}
}
let instruction_path = path.iter().map(|idx| graph[*idx]).collect();

(instruction_path, branch_decisions)
}

// TODO: write a unit test without dependency on selfie and external files
#[test]
#[serial]
Expand Down
63 changes: 63 additions & 0 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ mod disassemble;
mod elf;
mod formula_graph;
mod iterator;
mod smt;
mod solver;
mod ternary;

Expand Down Expand Up @@ -71,6 +72,68 @@ fn main() {
Ok(())
});
}
("smt", Some(_cfg_args)) => {
handle_error(|| -> Result<(), String> {
use crate::{
dead_code_elimination::eliminate_dead_code,
formula_graph::{build_dataflow_graph, extract_candidate_path},
};
use petgraph::dot::Dot;
use std::env::current_dir;
use std::fs::File;
use std::io::Write;
use std::process::Command;

let cd = String::from(current_dir().unwrap().to_str().unwrap());

// generate RISC-U binary with Selfie
let _ = Command::new("docker")
.arg("run")
.arg("-v")
.arg(cd + ":/opt/monster")
.arg("cksystemsteaching/selfie")
.arg("/opt/selfie/selfie")
.arg("-c")
.arg("/opt/monster/symbolic/symbolic-exit.c")
.arg("-o")
.arg("/opt/monster/symbolic/symbolic-exit.riscu.o")
.output();

let test_file = Path::new("symbolic/symbolic-exit.riscu.o");

let (graph, data_segment, elf_metadata) = cfg::build_from_file(test_file).unwrap();

// println!("{:?}", data_segment);

let (path, branch_decisions) = extract_candidate_path(&graph);

// println!("{:?}", path);

let (formula, _root) = build_dataflow_graph(
&path,
data_segment.as_slice(),
elf_metadata,
branch_decisions,
)
.unwrap();

let graph_wo_dc = eliminate_dead_code(&formula, _root);

let dot_graph = Dot::with_config(&graph_wo_dc, &[]);

let mut f = File::create("tmp-graph.dot").unwrap();
f.write_fmt(format_args!("{:?}", dot_graph)).unwrap();

let dot_graph = Dot::with_config(&formula, &[]);

let mut f = File::create("tmp-graph.dot").unwrap();
f.write_fmt(format_args!("{:?}", dot_graph)).unwrap();

smt::smt(&formula);

Ok(())
});
}
_ => unreachable!(),
}
}
Loading