Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom kernel call #161

Merged
merged 24 commits into from
May 4, 2023
Merged

Improve custom kernel call #161

merged 24 commits into from
May 4, 2023

Conversation

StRigaud
Copy link
Member

add std::map<std::string, std::variant<cle::Image, float, int>> as a futur holder for parameter list
add typedef : ParametersMap
update custom kernel to fit execute from the prototype version for compatibility

@StRigaud StRigaud added the request New feature or request label Apr 20, 2023
@StRigaud StRigaud self-assigned this Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.01 ⚠️

Comparison is base (9d55b53) 78.01% compared to head (ce24a16) 78.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.01%     
==========================================
  Files         272      272              
  Lines        9665     9681      +16     
==========================================
+ Hits         7540     7552      +12     
- Misses       2125     2129       +4     
Impacted Files Coverage Δ
clic/include/core/cleImage.hpp 100.00% <ø> (ø)
clic/src/core/cleProcessor.cpp 71.56% <0.00%> (ø)
clic/src/tier1/cleCustomKernel.cpp 79.16% <57.14%> (-4.84%) ⬇️
clic/include/tier1/cleCustomKernel.hpp 81.25% <78.57%> (-18.75%) ⬇️
tests/custom_kernel_test.cpp 96.66% <100.00%> (+0.83%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StRigaud StRigaud merged commit 1f77c77 into master May 4, 2023
@StRigaud StRigaud deleted the improve-custom-kernel-call branch May 4, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants