Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci with pocl and test #53

Merged
merged 35 commits into from
Mar 22, 2023
Merged

update ci with pocl and test #53

merged 35 commits into from
Mar 22, 2023

Conversation

StRigaud
Copy link
Member

No description provided.

@StRigaud StRigaud self-assigned this Jan 18, 2023
@StRigaud
Copy link
Member Author

All look good now to test pyclesperanto with pocl, still need to add some more test and a coverage stat for fun.
Also make sure this is flexible without pocl or conda environment

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@61e92b2). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #53   +/-   ##
======================================
  Coverage        ?   1.95%           
======================================
  Files           ?      17           
  Lines           ?     715           
  Branches        ?       0           
======================================
  Hits            ?      14           
  Misses          ?     701           
  Partials        ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StRigaud
Copy link
Member Author

This should be ready to merge.

What to remember from this PR:

  • We can make CMake search for OpenCL first in the Conda env by populating the CMAKE_PREFIX_PATH var.
  • POCL provide an OpenCL ICD against which CLIc and pyclesperanto can build on. More test in future should be done on if this ICD can see or not the devices outside the conda env.
  • The compiled pyclesperanto.so lib could not find the libOpenCL even though it was used for compilation. Dynamic links where not saved. Filling the LD_LIBRARY_PATH was an option (not great), better alternative is to update the RPATH of the library in CMAKE. Full detail on how this works was not clear.

Lets merge this and see where it goes 🚀

@StRigaud StRigaud added dependencies Pull requests that update a dependency file github_actions labels Mar 22, 2023
@StRigaud StRigaud linked an issue Mar 22, 2023 that may be closed by this pull request
@StRigaud StRigaud merged commit 60f5291 into main Mar 22, 2023
@StRigaud StRigaud deleted the CI-with-pocl branch March 22, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test fail when using oclgrind or pocl
2 participants