Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: device_type option to device #69

Merged
merged 10 commits into from
Apr 13, 2023
Merged

ADD: device_type option to device #69

merged 10 commits into from
Apr 13, 2023

Conversation

StRigaud
Copy link
Member

No description provided.

@StRigaud StRigaud added the api label Mar 24, 2023
@StRigaud StRigaud self-assigned this Mar 24, 2023
@StRigaud
Copy link
Member Author

CI should fail because py-clesperanto is relying on the master branch of CLIc for now and

is not merged yet

@StRigaud StRigaud added the request New feature or request label Apr 11, 2023
@StRigaud
Copy link
Member Author

@haesleinhuepf If you wanna have a look at the multi_gpu demo

Specific device can be instantiate with the new_device() function then, except for the push, create_like, pull, and kernel operation will reuse the input image device if the image is already pushed.
Warning and assert to make sure all is good are still missing though, also we would need to make sure it does not interfere with a more classic usage of the API.

PS: CIs are breaking but that should be ok as I know the source of it (I hope). This is mainly related to the wrong GIT TAG linking pyclesperanto to CLIc version.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.20 ⚠️

Comparison is base (24a8ea1) 1.87% compared to head (79a05b9) 1.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #69      +/-   ##
========================================
- Coverage   1.87%   1.68%   -0.20%     
========================================
  Files         17      18       +1     
  Lines        745     830      +85     
========================================
  Hits          14      14              
- Misses       731     816      +85     
Impacted Files Coverage Δ
pyclesperanto/__init__.py 0.00% <0.00%> (ø)
pyclesperanto/_decorators.py 0.00% <0.00%> (ø)
pyclesperanto/_device.py 0.00% <0.00%> (ø)
pyclesperanto/_image.py 0.00% <0.00%> (ø)
pyclesperanto/_memory_operations.py 0.00% <0.00%> (ø)
pyclesperanto/_types.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StRigaud StRigaud merged commit c6bc62b into main Apr 13, 2023
@StRigaud StRigaud deleted the add-device-type-option branch April 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants