-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precompiled wheel #657
Comments
Your assessment sounds correct, so if you could do something like that it would be greatly appreciated! |
I've made the actual v2.0 release here, so I think it'd be great to revisit this: |
Great news! For now I uploaded the source distribution to PyPI, so v2.0 can already be installed by |
Once #783 is merged, this should be possible by
auditwheel puts the libdynet.so into the wheel and fixes RPATH. |
When I'm trying this, I'm getting:
Waiting for pypa/auditwheel#36 to be fixed so I know what to change in my environment. |
Using the Docker image recommended by auditwheel, I was able to build the wheel:
I uploaded this to PyPI as version
|
Awesome, this is excellent! A couple things:
(No need to handle all of these at once, just asking for clarification about possibilities.) |
If this works well, I'll upload an official one for the next release. |
I think tensorflow has a |
By the way, is there a date planned for the next release? :) |
I was resolving bugs that popped up due to the introduction of multi-device support, but I think we're almost finished, so maybe this weekend? |
OK, release is done! |
Great! Working on the wheels. |
Uploaded 2.0.1 to PyPI, pre-compiled for Linux (32/64 bit) and macOS (64 bit), for Python 2.7, 3.4, 3.5 and 3.6. |
Installation of the
master
branch with pip is currently supported bypip install git+https://github.com/clab/dynet#egg=dynet
.To support installation by a simple
pip install dynet
(and versioning!), we need to upload a binary distribution package to PyPI. I think it would be a good idea to upload a precompiled .whl file, to reduce installation time significantly. It must be a separate file for Linux, OSX and Windows, compiled on the respective systems. I think this should be done once there is a 2.0 release.However, I'm pretty sure it won't work with the current configuration where there is a main
setup.py
calling thepython/setup.py
which is generated fromsetup.py.in
, because this way the main one doesn't know about the Cython extensions, and they are missing from the created wheel. Therefore, I believe the twosetup.py
files should be combined into a single static one, maybe replacing the CMake${...}
directives by environment variables or parameters.The text was updated successfully, but these errors were encountered: